Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ANCHOR-809] Improve new field naming #173

Merged
merged 2 commits into from
Nov 19, 2024
Merged

[ANCHOR-809] Improve new field naming #173

merged 2 commits into from
Nov 19, 2024

Conversation

JiahuiWho
Copy link
Contributor

@JiahuiWho JiahuiWho commented Nov 18, 2024

Rename new field to funding_methods in info response per final protocol change in https://github.com/stellar/stellar-protocol/pull/1567/files

It will remain funding_method in post request

@stellar-jenkins
Copy link

Copy link
Contributor

@philipliu philipliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comment

@@ -1,6 +1,6 @@
{
"name": "@stellar/anchor-tests",
"version": "0.6.17",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We never released 0.6.17 so I think it's ok if we don't need to bump the version.

@JiahuiWho JiahuiWho merged commit 1b3fa3c into master Nov 19, 2024
1 check was pending
@JiahuiWho JiahuiWho deleted the anchor-809 branch November 19, 2024 00:53
@stellar-jenkins
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants