Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ANCHOR-804] Make the fields of the SEP31 /info endpoint optional #154

Merged
merged 1 commit into from
Sep 6, 2024
Merged

[ANCHOR-804] Make the fields of the SEP31 /info endpoint optional #154

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
52 changes: 27 additions & 25 deletions @stellar/anchor-tests/src/tests/sep31/info.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,7 @@ export const hasExpectedAssetEnabled: Test = {
};

const hasExpectedTransactionFields: Test = {
assertion: "has configured transaction 'fields'",
assertion: "check optional transaction 'fields'",
sep: 31,
group: "GET /info",
dependencies: [hasValidInfoSchema],
Expand Down Expand Up @@ -184,31 +184,33 @@ const hasExpectedTransactionFields: Test = {
// this is checked before tests are run
throw new Error("improperly configured");
const result: Result = { networkCalls: [] };
const responseTransactionFields =
this.context.expects.sep31InfoObj.receive[config.assetCode].fields
.transaction;
const responseTransactionFieldNames = Object.keys(
responseTransactionFields,
);
const configuredTransactionFieldNames = Object.keys(
config.sepConfig["31"].transactionFields,
);
for (const fieldName of responseTransactionFieldNames) {
if (
!responseTransactionFields[fieldName].optional &&
!configuredTransactionFieldNames.includes(fieldName)
) {
result.failure = makeFailure(this.failureModes.UNEXPECTED_FIELD, {
field: fieldName,
});
return result;
if (this.context.expects.sep31InfoObj.receive[config.assetCode].fields) {
const responseTransactionFields =
this.context.expects.sep31InfoObj.receive[config.assetCode].fields
.transaction;
const responseTransactionFieldNames = Object.keys(
responseTransactionFields,
);
const configuredTransactionFieldNames = Object.keys(
config.sepConfig["31"].transactionFields,
);
for (const fieldName of responseTransactionFieldNames) {
if (
!responseTransactionFields[fieldName].optional &&
!configuredTransactionFieldNames.includes(fieldName)
) {
result.failure = makeFailure(this.failureModes.UNEXPECTED_FIELD, {
field: fieldName,
});
return result;
}
}
}
for (const fieldName of configuredTransactionFieldNames) {
if (!responseTransactionFieldNames.includes(fieldName)) {
result.failure = makeFailure(this.failureModes.FIELD_NOT_FOUND);
result.expected = fieldName;
return result;
for (const fieldName of configuredTransactionFieldNames) {
if (!responseTransactionFieldNames.includes(fieldName)) {
result.failure = makeFailure(this.failureModes.FIELD_NOT_FOUND);
result.expected = fieldName;
return result;
}
}
}
return result;
Expand Down