Check to make sure testRun exists #112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quietbits
commented
Jun 6, 2023
| sepArray.progress.failed++; | ||
| } else { | ||
| sepArray.progress.passed++; | ||
| if (testRun) { |
There was a problem hiding this comment.
@Ifropc I'm not sure if this is a correct fix, but at least it won't break the UI. It looks like the tests are still running, so we could look for ways to not run them at all.
There was a problem hiding this comment.
Looks good! Getting rid of delay would be nice, but it's ok for now
|
Preview is available here: |
Ifropc
approved these changes
Jun 6, 2023
piyalbasu
approved these changes
Jun 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This check will not break the flow if
testRundoes not exist in cases where we filter out a certain group of tests. For example,"Account Signer Support" in SEP-10 on mainnet here.