Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove major version upgrades from dependabot #1012

Merged
merged 2 commits into from
Jul 19, 2024
Merged

Conversation

Shaptic
Copy link
Contributor

@Shaptic Shaptic commented Jul 17, 2024

This removes the major version upgrade PRs such as #1011 from dependabot's automatic process. This is because major versions often require significant code changes and also often have other breaking changes such as dropping support for certain environments that we need to support. I regularly evaluate the workload needed to support the major upgrades whenever doing releases (e.g., in #993 you can see lots of dependency upgrades), so the automated process isn't necessary and in fact is risky in keeping this repository stable.

(Also for some reason yarn _prettier needed to be run to auto-format some test files which were causing CI to fail.)

@Shaptic Shaptic requested a review from kanwalpreetd July 17, 2024 17:06
Copy link

Size Change: 0 B

Total Size: 12.1 MB

ℹ️ View Unchanged
Filename Size
dist/stellar-sdk.js 6.78 MB
dist/stellar-sdk.min.js 5.34 MB

compressed-size-action

@Shaptic Shaptic merged commit e4b3d2f into master Jul 19, 2024
10 checks passed
@Shaptic Shaptic deleted the fixup-dependabot branch July 19, 2024 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants