Skip to content
This repository was archived by the owner on Mar 11, 2025. It is now read-only.

Release v0.7.1, fixing browser bundling bugs. #95

Merged
merged 6 commits into from
May 25, 2023
Merged

Conversation

Shaptic
Copy link
Contributor

@Shaptic Shaptic commented May 25, 2023

This partially fixes #94, allowing the library to be imported as:

import * as SorobanClient from 'soroban-client';

in browser environments.

It also broadens the bundles' JS compatibility, reverting #90.

@Shaptic
Copy link
Contributor Author

Shaptic commented May 25, 2023

tagging @esteblock, @piyalbasu, and @sreuland for review

@Shaptic Shaptic requested review from sreuland and piyalbasu May 25, 2023 21:28
Copy link
Contributor

@sreuland sreuland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, do you by chance know why the existing headless browser tests for chrome/firefox didn't replicate the same problem? those tests use the /dist correct? seems like constructor_test.js should have tripped on it also.

@esteblock
Copy link

I tried and worked both for my create-react-app and my-next-app experiments.
Now will try with the library

@Shaptic
Copy link
Contributor Author

Shaptic commented May 25, 2023

To be honest, I don't know. Karma relies on karma.conf.js to inject stuff into the webpack config, so maybe there is some magic happening there... in test/test-browser.js, there's not even a need for an import.

@esteblock
Copy link

Worked in @soroban-react!
For now I did a new alpha release:

Changes:

  • @soroban-react/chains: 4.5.1-alpha.0 => 4.5.1-alpha.1
  • @soroban-react/connect-button: 4.5.1-alpha.0 => 4.5.1-alpha.1
  • @soroban-react/contracts: 4.5.1-alpha.0 => 4.5.1-alpha.1
  • @soroban-react/core: 4.5.1-alpha.0 => 4.5.1-alpha.1
  • @soroban-react/events: 4.5.1-alpha.0 => 4.5.1-alpha.1
  • @soroban-react/utils: 4.5.1-alpha.0 => 4.5.1-alpha.1
  • @soroban-react/wallet-data: 4.5.1-alpha.0 => 4.5.1-alpha.1

Waiting for 0.7.1 !

@Shaptic Shaptic merged commit 23ce044 into main May 25, 2023
@Shaptic Shaptic deleted the webpack-export-defaults branch May 25, 2023 22:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Server constructor error in browser v0.7.0
4 participants