This repository was archived by the owner on Mar 11, 2025. It is now read-only.
Repair documentation generator and broaden bundle compatibility #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsachiherman
approved these changes
May 22, 2023
sreuland
reviewed
May 23, 2023
| "clean": "rm -rf lib/ dist/ coverage/ .nyc_output/", | ||
| "docs": "jsdoc -c ./.jsdoc.json --verbose", | ||
| "build:node": "yarn _babel && yarn build:ts", | ||
| "build:ts": "tsc -p ./tsconfig.json", |
There was a problem hiding this comment.
tsc looks for this file by default in this location also correct, just wanted to understand if the extra config is for something non-default or just readability.
There was a problem hiding this comment.
ah yeah this is just a copy-paste remnant from stellar-sdk where the files live in config/
sreuland
approved these changes
May 23, 2023
stellarsaur
pushed a commit
that referenced
this pull request
May 23, 2023
* Generate annotated .js files for docgen * Use docs env only for jsdoc, development otherwise (thx webpack)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See related stellar/js-stellar-sdk#833.
Docs weren't working before, but they should now:
yarn build:docs)yarn docs)yarn prepare, etc.)Closes #85.