This repository was archived by the owner on Mar 11, 2025. It is now read-only.
include ts.d files in output lib #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsachiherman
approved these changes
May 22, 2023
Shaptic
approved these changes
May 22, 2023
There was a problem hiding this comment.
Had a similar realization in stellar/js-stellar-sdk#830, didn't think to check here. Thanks!
package.json
Outdated
| @@ -27,7 +27,8 @@ | |||
| "scripts": { | |||
| "build": "cross-env NODE_ENV=development yarn _build", | |||
| "build:prod": "cross-env NODE_ENV=production yarn _build", | |||
| "build:node": "babel --extensions '.ts' --out-dir lib/ src/", | |||
| "build:ts": "npx tsc", | |||
There was a problem hiding this comment.
using yarn run tsc would be better for consistency
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the *.ts.d files were not being included in the lib output, causing ts validation errors for downstream client usage of types.
Closes #81