This repository was archived by the owner on Mar 11, 2025. It is now read-only.
Remove phantomjs from dev dependencies #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ages for recent distros like ubuntu, doesn't appear to be referenced by anything in here and it causes errors during install on machines running newer distros since it requires the bin on path
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
phantomjs is approaching eol and not published as a package for recent distros like ubuntu 22.04, it's not referenced by any tests here so, removing it as this is causing an issue in npm when building js-soroban-client from hosts that can't get the phantom js bin installed which is required on host path for
npm installto work with this dependency in place.