This repository was archived by the owner on Mar 11, 2025. It is now read-only.
soroban-rpc: Replace getLedgerEntry with getLedgerEntries #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shaptic
approved these changes
May 23, 2023
Thanks for the review! Done |
Shaptic
suggested changes
May 23, 2023
CHANGELOG.md
Outdated
Comment on lines
5
to
9
| A breaking change should be clearly marked in this log. | ||
|
|
||
| #### 0.6.2 | ||
| * replaced `getLedgerEntry` with `getLedgerEntries`. `getLedgerEntry` is deprecated and should no longer be used. | ||
|
|
There was a problem hiding this comment.
lol sorry, this isn't ready for release / a final decision on version bump. you should keep it in the "Unreleased" section and we'll tag it when we're ready. also marking it as breaking more explicitly!
Suggested change
| A breaking change should be clearly marked in this log. | |
| #### 0.6.2 | |
| * replaced `getLedgerEntry` with `getLedgerEntries`. `getLedgerEntry` is deprecated and should no longer be used. | |
| A breaking change should be clearly marked in this log. | |
| * **Breaking Change**: Replaced `getLedgerEntry` with `getLedgerEntries`. `getLedgerEntry` is deprecated and should no longer be used ([#66](https://github.com/stellar/js-soroban-client/pull/66)). | |
Shaptic
approved these changes
May 23, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces instances of getLedgerEntry with getLedgerEntries.
Related to this issue
Need to wait until this PR is deployed to merge this. Tests will fail in the meantime due to them using live endpoints.