Skip to content
This repository was archived by the owner on Mar 11, 2025. It is now read-only.

Handle events without contract IDs correctly #172

Merged
merged 5 commits into from
Dec 1, 2023
Merged

Conversation

Shaptic
Copy link
Contributor

@Shaptic Shaptic commented Nov 27, 2023

This mirrors stellar/js-stellar-sdk#883.

It also adds a migration guide with justifications and details alongside a deprecation message that people will see when installing soroban-client.

@Shaptic Shaptic requested a review from sreuland November 30, 2023 21:18
@Shaptic Shaptic force-pushed the deprecation-message branch from 2e01180 to 25095df Compare November 30, 2023 21:23
@Shaptic Shaptic self-assigned this Nov 30, 2023
@Shaptic Shaptic added the bug Something isn't working label Nov 30, 2023
Copy link
Contributor

@sreuland sreuland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@Shaptic Shaptic force-pushed the deprecation-message branch from 47327aa to f1e540f Compare December 1, 2023 21:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants