Skip to content
This repository was archived by the owner on Mar 11, 2025. It is now read-only.

fix(spec): unwrap result when parsing return value #138

Merged
merged 2 commits into from
Sep 11, 2023
Merged

fix(spec): unwrap result when parsing return value #138

merged 2 commits into from
Sep 11, 2023

Conversation

willemneal
Copy link
Contributor

@willemneal willemneal commented Sep 8, 2023 •
edited
Loading

This PR unwraps the result type's ok type so that it can be parsed correctly. The error type is used when if it throws.
fixes: stellar/stellar-cli#935

@kalepail kalepail requested a review from Shaptic September 8, 2023 15:29
Shaptic
Shaptic approved these changes Sep 11, 2023
View reviewed changes
Copy link
Contributor

@Shaptic Shaptic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one small non-blocking nit, otherwise lgtm! a changelog entry would also be appreciated

@willemneal willemneal merged commit 4b77acf into stellar:main Sep 11, 2023
@willemneal willemneal deleted the fix/spec_enums branch September 11, 2023 19:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Shaptic Shaptic Shaptic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@willemneal @Shaptic