Karthik/5591/protos for ttp #5596
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karthikiyer56
force-pushed
the
karthik/5591/protos-for-ttp
branch
from
290ee40 to
784b018
Compare
sreuland
reviewed
Feb 10, 2025
sreuland
reviewed
Feb 10, 2025
…nsistent with where the generated code should appear This also helps simply the Makefile target Right now, yes, the protos that we need to work on need to be put in the /ingest path. Tomorrow, we may need to have generated go files in some other path for some other source code. At that time, redoing protos might be hard.
karthikiyer56
commented
Feb 10, 2025
sreuland
reviewed
Feb 10, 2025
tamirms
reviewed
Feb 11, 2025
tamirms
reviewed
Feb 11, 2025
tamirms
approved these changes
Feb 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This PR deals with implementing protos as defined in issue 5591