Detect Middlewares #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 similar comment
jerguslejko
reviewed
Oct 12, 2017
We first resolve the HTTP Kernel and check if the kernel has the given middleware registered. If the kernel return false on `hasMiddleware` we create a collection of middlewares registered on the router and check if the given Middleware exists in that collection
This was referenced Oct 15, 2017
|
I have submitted a PR that contains an update to get the route middlewares in addition to the global middlewares: #140. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for Middlewares.
The ReflectionClass resolves the Router and gets declared Middlewares from
$middlewareand$middlewareGroups. If the given Middleware Classname exists in the Middleware Collection the class has been "recognized".Known Bugs
$middlewareclass are currently not recognized 😞Related Issues
TODOs