Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor ProjectStatistics API #102

Merged
merged 2 commits into from
Oct 25, 2017
Merged

Refactor ProjectStatistics API #102

merged 2 commits into from
Oct 25, 2017

Conversation

jerguslejko
Copy link
Contributor

This PR cleans up ProjectStatistics API. Passing result from $stats->generate() to $stats->getTotalRow() feels really weird. It suggests that we are missing an abstraction of "ComponentAnalyser". We can take a look into that once the API stabilizes.

@stefanzweifel stefanzweifel merged commit 0705bd0 into stefanzweifel:master Oct 25, 2017
@stefanzweifel
Copy link
Owner

Solid work. I definitely agree, that the $stats->getTotalRow() thing was kinda ugly.
I really like the components() and other() methods. In order to get #21 forward, we will have to sort component in 2 "meta-groups" (application-code and test-code). I think this could happen here (or in a new class and the ProjectStatistics class gets the data from the new class)

@jerguslejko jerguslejko deleted the project-stats branch October 25, 2017 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants