Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Respect namespace of current KubeConfig context #40

Merged
merged 1 commit into from
Mar 31, 2023
Merged

Respect namespace of current KubeConfig context #40

merged 1 commit into from
Mar 31, 2023

Conversation

hiddeco
Copy link
Contributor

@hiddeco hiddeco commented Mar 31, 2023

This changes the hardcoded "default" to respect the namespace of the active KubeConfig context, if usable.

Fixes #39

@hiddeco
Respect namespace of current KubeConfig context
23115bf 
This changes the hardcoded "default" to respect the namespace of the
active KubeConfig context, if usable.

Signed-off-by: Hidde Beydals <[email protected]>
stefanprodan
stefanprodan approved these changes Mar 31, 2023
View reviewed changes
Copy link
Owner

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @hiddeco 🥇

@stefanprodan stefanprodan added the area/cli CLI related issues and pull requests label Mar 31, 2023
@stefanprodan stefanprodan merged commit c72e964 into stefanprodan:main Mar 31, 2023
@hiddeco hiddeco deleted the use-kubectx-ns branch March 31, 2023 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stefanprodan stefanprodan stefanprodan approved these changes

Assignees
No one assigned
Labels
area/cli CLI related issues and pull requests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

timoni --namespace doesn't respect the default ns set in kubeconfig context
2 participants
@hiddeco @stefanprodan