Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add --name flag to timoni mod vet command #272

Merged
merged 5 commits into from
Dec 15, 2023
Merged

Add --name flag to timoni mod vet command #272

merged 5 commits into from
Dec 15, 2023

Conversation

Nalum
Copy link
Contributor

@Nalum Nalum commented Dec 8, 2023 •
edited
Loading

Running timoni mod vet --name cert-manager --namespace cert-manager will result in the the following output where the module name is cert-manager instead of default.

9:49AM INF vetting with default values
9:49AM INF Namespace/cert-manager valid resource
9:49AM INF Deployment/cert-manager/cert-manager-controller valid resource
9:49AM INF Deployment/cert-manager/cert-manager-webhook valid resource
9:49AM INF quay.io/jetstack/cert-manager-acmesolver:v1.13.2@sha256:7057fd605f530ab2198ebdf1cb486818cce20682632be37c90522a09b95271b1 valid image
9:49AM INF quay.io/jetstack/cert-manager-cainjector:v1.13.2@sha256:858fee0c4af069d0e87c08fd0943f0091434e05f945d222875fc1f3d36c41616 valid image
9:49AM INF quay.io/jetstack/cert-manager-controller:v1.13.2@sha256:9c67cf8c92d8693f9b726bec79c2a84d2cebeb217af6947355601dec4acfa966 valid image
9:49AM INF quay.io/jetstack/cert-manager-ctl:v1.13.2@sha256:4d9fce2c050eaadabedac997d9bd4a003341e9172c3f48fae299d94fa5f03435 valid image
9:49AM INF quay.io/jetstack/cert-manager-webhook:v1.13.2@sha256:0a9470447ebf1d3ff1c172e19268be12dc26125ff83320d456f6826c677c0ed2 valid image
9:49AM INF timoni.sh/cert-manager valid module

Closes #269

@Nalum
Setup name flag for the vet command
45ab6df 
Signed-off-by: Luke Mallon (Nalum) <[email protected]>
@Nalum Nalum marked this pull request as draft December 8, 2023 10:18
@Nalum
Additional tests
57cd78a 
Signed-off-by: Luke Mallon (Nalum) <[email protected]>
stefanprodan
stefanprodan reviewed Dec 11, 2023
View reviewed changes
@stefanprodan stefanprodan added the area/cli CLI related issues and pull requests label Dec 11, 2023
@stefanprodan stefanprodan changed the title Setup name flag for timoni mod vet Add --name flag for timoni mod vet Dec 11, 2023
@stefanprodan stefanprodan changed the title Add --name flag for timoni mod vet Add --name flag to timoni mod vet command Dec 11, 2023
@Nalum @stefanprodan
Update cmd/timoni/mod_vet.go
70410c7 
Co-authored-by: Stefan Prodan <[email protected]>
Nalum
Nalum commented Dec 12, 2023
View reviewed changes
@Nalum Nalum marked this pull request as ready for review December 12, 2023 11:55
@Nalum
Set the default name value in the resetCmdArgs function and ignore na…
7ca559f 
…mespace unless explicitly set

Signed-off-by: Luke Mallon (Nalum) <[email protected]>
@Nalum Nalum requested a review from stefanprodan December 15, 2023 09:41
stefanprodan
stefanprodan approved these changes Dec 15, 2023
View reviewed changes
Copy link
Owner

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @Nalum 🏅

@stefanprodan stefanprodan merged commit 97f1e35 into stefanprodan:main Dec 15, 2023
@Nalum Nalum deleted the issue-269-vet-name-tag branch December 15, 2023 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stefanprodan stefanprodan stefanprodan approved these changes

Assignees
No one assigned
Labels
area/cli CLI related issues and pull requests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

timoni mod vet Name
2 participants
@Nalum @stefanprodan