save and destroy currentLineBuffer

steelbrain · Sep 22, 2020 · b5d7cd0 · b5d7cd0
1 parent bf30d02
commit b5d7cd0
Showing 1 changed file with 12 additions and 5 deletions.
diff --git a/lib/editor/index.js b/lib/editor/index.js
@@ -25,6 +25,7 @@ class Editor {
   showDecorations: boolean
   showProviderName: boolean
   ignoreTooltipInvocation: boolean
+  currentLineMarker: ?BufferMarker
 
   constructor(textEditor: TextEditor) {
     this.tooltip = null
@@ -34,6 +35,7 @@ class Editor {
     this.textEditor = textEditor
     this.subscriptions = new CompositeDisposable()
     this.ignoreTooltipInvocation = false
+    this.currentLineMarker = null
 
     this.subscriptions.add(this.emitter)
     this.subscriptions.add(
@@ -127,7 +129,6 @@ class Editor {
   listenForCurrentLine() {
     this.subscriptions.add(
       this.textEditor.observeCursors(cursor => {
-        let marker
         let lastRange
         let lastEmpty
         const handlePositionChange = ({ start, end }) => {
@@ -145,16 +146,19 @@ class Editor {
             linesRange.end.row--
           }
           if (lastRange && lastRange.isEqual(linesRange) && currentEmpty === lastEmpty) return
-          if (marker) marker.destroy()
+          if (this.currentLineMarker) {
+            this.currentLineMarker.destroy()
+            this.currentLineMarker = null
+          }
           lastRange = linesRange
           lastEmpty = currentEmpty
 
-          marker = this.textEditor.markScreenRange(linesRange, {
+          this.currentLineMarker = this.textEditor.markScreenRange(linesRange, {
             invalidate: 'never',
           })
           const item = document.createElement('span')
           item.className = `line-number cursor-line linter-cursor-line ${currentEmpty ? 'cursor-line-no-selection' : ''}`
-          gutter.decorateMarker(marker, {
+          gutter.decorateMarker(this.currentLineMarker, {
             item,
             class: 'linter-row',
           })
@@ -178,7 +182,10 @@ class Editor {
         )
         subscriptions.add(
           new Disposable(function() {
-            if (marker) marker.destroy()
+            if (this.currentLineMarker) {
+              this.currentLineMarker.destroy()
+              this.currentLineMarker = null
+            }
           }),
         )
         this.subscriptions.add(subscriptions)