Get rid of form-2 subs in defview #11148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins Builds
|
|
i still think form-2 should be used, if you need to pass a parameter from another subscription, that means subscriptions was incorrectly designed |
|
@flexsurfer please elaborate why form-2 should be used (just reminder) |
We have a safe way to not care about "incorrect design" (that's kind of arguable) and bugs caused by it, so what's the reason to not use it? |
|
yeah i know it will work, and its not critical, it's just my personal preference, however, i don't mind to follow any team's decision, and i know most devs for removing defview, so i'll approve this PR, but suggest to replace |
flexsurfer
approved these changes
Sep 10, 2020
that's fine, but this PR is not about removing
I would also consider some punishment for the retard who introduced |
100% of end-end tests have passedPassed tests (99)Click to expand
|
rasom
force-pushed
the
get-rid-of-form-2
branch
from
e3126e2 to
f9df0f3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't need form-2 subs and those subs cause bugs in
defviewwhen they have parameters. This PR solves it. Next step would be removingdefviewfrom code.status: ready