Fix /eth/v1/node/syncing #3720
Fix /eth/v1/node/syncing #3720
Conversation
…ager is not running.
beacon_chain/rpc/rest_node_api.nim
Outdated
| distance = wallSlot - headSlot | ||
| info = RestSyncInfo( | ||
| head_slot: headSlot, sync_distance: distance, | ||
| is_syncing: distance != 0'u64 |
There was a problem hiding this comment.
this is too strict, ie it'll show up as syncing at the start of every slot, in the period between the start of the slot and until we've received a block. why is syncmanager itself not giving a correct value here?
There was a problem hiding this comment.
Because there so many different type of sync, that syncmanager is not always running.
There was a problem hiding this comment.
This call should be reporting the progress of the ordinary forward sync that we use to chase head after the node goes offline
There was a problem hiding this comment.
Requests the beacon node to describe if it's currently syncing or not, and if it is, what block it is up to.
There is no mention on type of sync.
Also people are using this function to check progress of checkpoint sync.
There was a problem hiding this comment.
I also think the expected definition of "synced" is "able to attest for the current head" (in other words, how far is our current head from the wall clock head). For the other types of syncing, we probably need separate API calls.
…/dag-statevars * commit '6bf7d6468036c3f010c6ce08727d63331ada5e0d': update CI timeouts (#3751) Fix /eth/v1/node/syncing (#3720) use block ID vs full block in LC data caching (#3741) cleanup LC data helpers (#3746) fix LC data import for Altair fork period (#3744) fix CI archive step (#3752) Support displaying the version number in the status bar; Implements #2959 (#3747) ci: install cmake on windows in daily job don't use slow-to-compress bzip2 with larger Jenkins artifacts rename light client config parameters (#3740) error handling for local testnet REST query (#3739) keep fcU consistent with actual DAG (#3748) remove unused `getExistingForkedBlock` overload (#3742) Version 22.5.2 change proposer boost to 40% bump merge-testnets to get new ropsten TTD (#3668)
Fix REST server
/eth/v1/node/syncingcall to return proper values even if SyncManager is not running.