Add framework to support more optional types #206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR add a framework to rpc server by using more templates than macros to handle optional types. Now rpc server recognize both `std/options` and `results.Opt` as optional type for the parameters. If needed user can add more optional types by overloading `rpc_isOptional` template. Now aliases to optional types also works.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR add a framework to rpc server by using more templates than macros to handle optional types.
RPC server recognize both
std/optionsandresults.Optas optional type for the parameters.If needed user can add more optional types by overloading
rpc_isOptionaltemplate. e.g. add support for or ptr/ref object as optional.Now aliases to optional types also works.
Optional object fields is handled by nim-json-rpc as usual. This PR is targeting optional parameters of RPC methods.
fix #202