Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert: "build(deps): bump github.com/distribution/distribution from 2.8.2+incompatible to 2.8.3+incompatible (#610)" #615

Closed
wants to merge 1 commit into from

Conversation

mikaelol
Copy link
Contributor

@mikaelol mikaelol commented Oct 5, 2023

This reverts commit f7ef887.

The golang-ci-lint-job is currently failing, I suspect it is the upgrade in #610 that causes this: https://github.com/statnett/image-scanner-operator/actions/runs/6421469698/job/17436293332

I can't understand why the job didn't run for that commit, it did run for the commit before and after:

image
(source)
Someone knows?

….8.2+incompatible to 2.8.3+incompatible (#610)"

This reverts commit f7ef887.
@mikaelol mikaelol changed the title Revert "build(deps): bump github.com/distribution/distribution from 2.8.2+incompatible to 2.8.3+incompatible (#610)" fix: Revert "build(deps): bump github.com/distribution/distribution from 2.8.2+incompatible to 2.8.3+incompatible (#610)" Oct 5, 2023
@mikaelol mikaelol changed the title fix: Revert "build(deps): bump github.com/distribution/distribution from 2.8.2+incompatible to 2.8.3+incompatible (#610)" fix: revert "build(deps): bump github.com/distribution/distribution from 2.8.2+incompatible to 2.8.3+incompatible (#610)" Oct 5, 2023
@mikaelol mikaelol marked this pull request as ready for review October 5, 2023 16:53
@mikaelol mikaelol requested a review from a team as a code owner October 5, 2023 16:53
@erikgb erikgb changed the title fix: revert "build(deps): bump github.com/distribution/distribution from 2.8.2+incompatible to 2.8.3+incompatible (#610)" revert: "build(deps): bump github.com/distribution/distribution from 2.8.2+incompatible to 2.8.3+incompatible (#610)" Oct 5, 2023
Copy link
Member

@erikgb erikgb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we will roll forward instead, ref. #616

@erikgb erikgb mentioned this pull request Oct 5, 2023
@erikgb erikgb closed this in #616 Oct 6, 2023
@mikaelol mikaelol deleted the revert-distribution-upgrade branch October 6, 2023 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants