Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.x] Add install:eloquent-driver command #9669

Merged
merged 45 commits into from
Apr 15, 2024

Conversation

duncanmcclean
Copy link
Member

@duncanmcclean duncanmcclean commented Mar 5, 2024

This pull request introduces a new install:eloquent-driver command which will simplify the process of installing & configuring the Eloquent Driver package.

This command will install the eloquent-driver package, then prompt the user to select which repositories they wish to migrate over and if they want to migrate existing content into the database or start fresh.

CleanShot 2024-03-06 at 19 23 09

Testing

For now, until v4 of the Eloquent Driver has been tagged, you'll need to tweak the package's version constraint in your composer.json in order for everything to work:

"statamic/eloquent-driver": "dev-statamic-5"

To Do

@duncanmcclean duncanmcclean marked this pull request as ready for review March 7, 2024 15:55
duncanmcclean and others added 7 commits March 15, 2024 16:03
When running the test suite on Laravel 10.0.0, Prompts would show me the interactive prompt, meaning the assertions wouldn't take place.

Related: laravel/framework#48468
Form submissions now have a dedicated driver in the config. See statamic/eloquent-driver#177
@duncanmcclean
Copy link
Member Author

Making this a draft for now until I'm done with my current round of tweaks.

@duncanmcclean duncanmcclean marked this pull request as draft April 10, 2024 23:09
@duncanmcclean
Copy link
Member Author

I've opened a PR on the Eloquent Driver to make changes to the importers, which should be reviewed/merged before reviewing this PR: statamic/eloquent-driver#269

Otherwise, this pull request is ready for review once more!

@duncanmcclean duncanmcclean marked this pull request as ready for review April 12, 2024 10:00
Copy link
Member

@jasonvarga jasonvarga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be good if you could test that there's a DB set up and configured correctly at the start of the command. Otherwise when you try to perform the migration step it'll crap itself and leave you in a weird state.

@jasonvarga jasonvarga merged commit 17ec219 into master Apr 15, 2024
31 checks passed
@jasonvarga jasonvarga deleted the install-eloquent-driver-command branch April 15, 2024 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants