[4.x] Antlers: Allow number literals inside variable bindings #9503
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes an existing papercut by allowing number literals inside Antlers parameter variable bindings. Currently, it is difficult/non-obvious on how one should go about passing a numeric value to a tag, as normal parameters are converted to strings:
We can now simply use variable binding syntax to pass along the numeric literal:
The current behavior would treat the numeric literal as a variable name, which is invalid, and always end up returning
null
, so I don't see this is as a breaking change. This PR does not automatically cast numeric values in all other situations since that would be a breaking change:The following will remain a string value:
The behavior of the following has not been changed, as it is possible for tags to start with numbers: