Add text align support to Bard #6450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds text align support to Bard by implementing the official Tiptap 2 TextAlign extension:
https://tiptap.dev/api/extensions/text-align
I think just enabling it for
headingandparagraphworks for everything you'd want it too, as Tiptap adds paragraphs inside list items and table cells.When enabled this extension does add a default
textAlignattribute to the nodes in the data, which is why I've had to tweak the tests. However when this is set toleftthe rendered HTML remains unchanged.This PR is for Bard 2 / TipTap 2 and targets the master branch.
Closes statamic/ideas#470