Skip to content
This repository has been archived by the owner on Jan 6, 2025. It is now read-only.

Update array functions for Statamic 5 / Laravel 11 #11

Merged
merged 8 commits into from
Oct 16, 2024
Merged

Update array functions for Statamic 5 / Laravel 11 #11

merged 8 commits into from
Oct 16, 2024

Conversation

dchymko
Copy link
Contributor

@dchymko dchymko commented Oct 16, 2024

Fixes function array_get() undefined on the second step of the importer when attempting to import the posts.

Is it worth including logic to keep it compatible with < 5.0?

Also, I believe @kevmarsden has some additional fixes that may supersede this one, in which case, this can be closed.

@ryanmitchell
Copy link
Contributor

Would be best for this to merge after #12 and then tidy up the merge conflicts

@kevmarsden
Copy link
Contributor

This PR works as expected as long as the config/statamic-wp-import.php file is renamed to wp-import.php.

There are still some issues with taxonomy imports, so I'll create a separate PR with those fixes once these pending PRs are merged.

@ryanmitchell
Copy link
Contributor

@kevmarsden I've reverted the config changes, looked like a find/replace error to me

@dchymko
Copy link
Contributor Author

dchymko commented Oct 16, 2024

@kevmarsden I've reverted the config changes, looked like a find/replace error to me

I changed the references, because with the plugin namespace/rename change to statamaic-rad-pack today, it was throwing an no hint path defined for error.

If you reinstall the add-on with composer, you should be able to reproduce.

@dchymko dchymko mentioned this pull request Oct 16, 2024
@jackmcdade jackmcdade merged commit 2519c02 into statamic-rad-pack:main Oct 16, 2024
@jackmcdade
Copy link
Contributor

Thank you!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants