Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make directors and photographers clickable in detail view #4621

Merged
merged 4 commits into from
Mar 13, 2024

Conversation

bdbenim
Copy link
Contributor

@bdbenim bdbenim commented Feb 26, 2024

This PR is meant to address #4568 by making director/photographer names clickable in scene, movie, gallery, and image detail views. A new component type DirectorLink is added based on TagLink which links to the scenes, galleries, or images page as applicable with a filter applied for items where the director/photographer EQUALS the name that was clicked.

The movie details page does not use this new component, in favour of a standard Link to better match the other detail items visually.

Close #4568

@WithoutPants WithoutPants added this to the Version 0.26.0 milestone Feb 29, 2024
@WithoutPants WithoutPants added the improvement Something needed tweaking. label Feb 29, 2024
@WithoutPants WithoutPants merged commit 49cd214 into stashapp:develop Mar 13, 2024
2 checks passed
halkeye pushed a commit to halkeye/stash that referenced this pull request Sep 1, 2024
)

* Make directors and photographers clickable
* Make director clickable on movie details page
---------
Co-authored-by: WithoutPants <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Something needed tweaking.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Make DIRECTOR and PHOTOGRAPHER fields actionable
2 participants