[WIP] Fix xPath scrapper blocked by some site with WAF #346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WithoutPants
changed the title
|
Marking this as WIP until I can make the change to make the User agent string configurable. |
|
An exhaustive list of user-agent strings https://developers.whatismybrowser.com/useragents/explore/ |
|
Opened #409 instead of pushing directly to @hiddenpants255 develop branch. Closing this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some site has WAF enabled and the default user-agent string of Go http client has been blocked by those firewalls.
The
antchfx/htmlquerypackage that we're using for xPath scraper has no way to specify the user-agent string to replace the default, I have implemented localloadURL()function with the same signature and set the user-agent to "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_2) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/79.0.3945.130 Safari/537.36" to bypass the firewall rules.