Fix countries with batch performer add/update #2326
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is going to collide/be obsoleted by #1922. |
|
Ok. Do you want me to close this and resubmit just the fix for Tattoos going into the Twitter field? It's just a one-liner. https://github.com/stashapp/stash/pull/2326/files#diff-84d0612ead36cb427339c97525ef8b6b2cb2effef835bb4dd5da31d3cc1ba075L145 |
|
I made a separate pull request for the tattoos -> twitter thing. #2332 Feel free to do whatever with this PR. |
|
Obsoleted by #1922. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had to add a new dependency. I don't know anything about GoLang so hopefully this is the right way. Also the license looks okay but of course double check to see if it works. https://github.com/biter777/countries
This should fix #1567. When doing a batch performer add or update, it converts the 2 character code to the full country name and stores it that way. I also tested this with a performer that had no country in StashDB to ensure it didn't cause issues.
This also fixes another issue I found which was assigning the "Tattoos" data from StashDB to the Twitter field. I figured it would be okay to include with this PR though.