Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug Report] Transcoding selector UI blocked by skip button on iPhone #4066

Closed
anonstash opened this issue Aug 27, 2023 · 0 comments · Fixed by #5229
Closed

[Bug Report] Transcoding selector UI blocked by skip button on iPhone #4066

anonstash opened this issue Aug 27, 2023 · 0 comments · Fixed by #5229
Labels
bug report Bug reports that are not yet verified

Comments

@anonstash
Copy link

Describe the bug
On an iPhone, the big buttons for playing/skipping block the transcoding selector UI. Only certain qualities can be selected as a result, and scrolling through the list is difficult.

To Reproduce
Steps to reproduce the behavior:

  1. On an iPhone, open any scene in Stash in Safari/Firefox
  2. Click on the gear to bring up the quality selection UI
  3. Notice that the big skip button blocks selecting most transcoding qualities

Expected behavior
User should be able to select any quality available. This should be able to be fixed by having the quality selection pop-up box be in front of the big playback buttons.

Screenshots
example

Stash Version: (from Settings -> About):
v0.22.1

Smartphone (please complete the following information):

  • Device: iPhone 12 Pro
  • OS: iOS 16.6
  • Browser: Safari/Firefox
  • Version: N/A
@anonstash anonstash added the bug report Bug reports that are not yet verified label Aug 27, 2023
@github-project-automation github-project-automation bot moved this to To triage in Bug fixing Feb 13, 2024
Gykes added a commit to Gykes/stash that referenced this issue Sep 6, 2024
@Gykes
Small CSS changes
8e5d162 
Small CSS change to allow the `source-selector` to be brought to the front of the controls to allow people to select which source they would like.

At first, I was going more complex. I created functions that would disable the `big-buttons` if a menu was open and I got it mostly working but I felt like it was overkill when we can modify like 3-4 lines of CSS and get the same result.

fixes stashapp#4066
@Gykes Gykes mentioned this issue Sep 6, 2024
Merged
@github-project-automation github-project-automation bot moved this from To triage to Done in Bug fixing Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug report Bug reports that are not yet verified
Projects
Bug fixing
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix source-selector being blocked on mobile Gykes/stash
1 participant
@anonstash