This repository has been archived by the owner on Sep 28, 2021. It is now read-only.
Feature/more emojis #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merging changes from upstream
…so the emojis and some infor about them can be found on the internet.
…er the entry 'zombie'.
…d rearranging some entries.
|
Whoa! 😮 |
Bugfix as there was one '[' too much due to searching and replacing to get arrays for all "name" entries.
And removed an additional '[' but now I should have them... ^^'
illusi0nary
suggested changes
Oct 5, 2020
lang/en.js
Outdated
| { | ||
| name: 'heart', | ||
| uniqueName: 'Anatomical Heart', | ||
| emoji: '🫀', |
There was a problem hiding this comment.
This seems to be correct - is that only me ?
I just see 🫀 - that might cause problems?
There was a problem hiding this comment.
Thanks for the hint. Some emojis are too new (e.g. "headstone" as well) so I changed them into comments and added the hint that they arrive later this year wit Unicode/Emoji 13.0, e.g. for Android 11.
lang/en.js
Outdated
| { | ||
| name: 'disguises', | ||
| uniqueName: 'Performing Arts', | ||
| emoji: '🥸', |
There was a problem hiding this comment.
Same here it is only showing 🫀
There was a problem hiding this comment.
The "Performing Arts" one actually was a copy-paste issue and should be fixed now. :)
Most of the not displayed emojis are too new so I changed the ones now into a comment and replaced the "Performing Arts" one as it seemed to have been a copy-paste issue. :/
LucasCtrl
approved these changes
Oct 6, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added more emojis for the English template and introduced the idea of using unique names that match the names used on https://emojipedia.org/halloween/ so that it is easier to identify, add and later also add more translations.