Skip to content
This repository has been archived by the owner on Jul 26, 2023. It is now read-only.

Commit

Permalink
feat: run on node 14 (#7)
Browse files Browse the repository at this point in the history
* feat: run on node 14

* ci: update test platforms in GHA

* ci: don't try to run docker action on non-Linux oses

* test: fix tests on windows

* ci: improve test result reporting

* style: fix lint
  • Loading branch information
starsprung authored Jan 3, 2021
1 parent 670db77 commit 9a8522d
Show file tree
Hide file tree
Showing 11 changed files with 105 additions and 18,615 deletions.
8 changes: 4 additions & 4 deletions .eslintrc.js
Original file line number Diff line number Diff line change
@@ -1,16 +1,16 @@
module.exports = {
env: {
es2020: true
es2020: true,
},
extends: ['eslint:recommended', 'plugin:@typescript-eslint/recommended'],
parser: '@typescript-eslint/parser',
parserOptions: {
ecmaVersion: 12,
sourceType: 'module'
sourceType: 'module',
},
plugins: ['@typescript-eslint'],
rules: {
'@typescript-eslint/no-unused-vars': ['error', { varsIgnorePattern: '^_' }],
'no-empty': 'off'
}
'no-empty': 'off',
},
};
2 changes: 1 addition & 1 deletion .github/workflows/lint.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ jobs:
- name: Setup Node
uses: actions/setup-node@v1
with:
node-version: 15.x
node-version: 14.x

- name: Cache Node.js modules
uses: actions/cache@v2
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ jobs:
if: ${{ github.event.workflow_run.conclusion == 'success' }}
uses: actions/setup-node@v1
with:
node-version: 15.x
node-version: 14.x

- name: Cache Node.js modules
if: ${{ github.event.workflow_run.conclusion == 'success' }}
Expand Down
22 changes: 19 additions & 3 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,15 +4,28 @@ on: push

jobs:
test:
runs-on: ubuntu-latest
strategy:
fail-fast: false
matrix:
os:
- macos-latest
- ubuntu-latest
- windows-latest
node-version:
- 14
- 15

runs-on: ${{ matrix.os }}

steps:
- name: Checkout code
uses: actions/checkout@v2

- name: Setup Node
uses: actions/setup-node@v1
with:
node-version: 15.x
with:
node-version: ${{ matrix.node-version }}

- name: Cache Node.js modules
uses: actions/cache@v2
Expand All @@ -33,7 +46,10 @@ jobs:

- name: Publish unit test results
uses: docker://ghcr.io/enricomi/publish-unit-test-result-action:v1.6
if: always()
if: runner.os == 'Linux'
with:
hide_comments: orphaned commits
check_name: Unit Test Results - ${{ matrix.os }} - node ${{ matrix.node-version }}
comment_title: Unit Test Statistics - ${{ matrix.os }} - node ${{ matrix.node-version }}
github_token: ${{ secrets.GITHUB_TOKEN }}
files: test-output/**/*.xml
1 change: 1 addition & 0 deletions .node-version
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
14.15.3
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ functionality, which generates e-mails from Amazon, [see below](#email-notificat

## Pre-requisites

- [Node.js](https://nodejs.org/) >= 15.x
- [Node.js](https://nodejs.org/) >= 14.15.0
- [Your YNAB personal access token](https://api.youneedabudget.com/#personal-access-tokens)
- Your Amazon.com login credentials
- On Linux some Puppeteer dependencies [may need to be manually installed](#troubleshooting)
Expand Down
Loading

0 comments on commit 9a8522d

Please sign in to comment.