Xor Documentation (#1000) #1000
Conversation
|
This change is |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #1000 +/- ##
=======================================
Coverage 92.91% 92.91%
=======================================
Files 105 105
Lines 14208 14208
Branches 14208 14208
=======================================
Hits 13202 13202
Misses 927 927
Partials 79 79 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @alon-f and @Gali-StarkWare)
crates/prover/src/examples/blake/preprocessed_columns.rs line 15 at r1 (raw file):
/// n_expand_bits), while storing another table for the n_expand_bits xor operation. /// The index_in_table is the column index in the preprocessed table (0 for the first number, 1 for /// the second number and 2 for the xor operation result).
Suggestion:
/// A preprocessed table for the xor operation of 2 n_bits numbers.
/// n_expand_bits is an optimization parameter reducing the table's cloumns' length to 2^(n_bits -
/// n_bits - n_expand_bits), while storing multiplicities for the n_expand_bits xor operation.
/// The index_in_table is the column index in the preprocessed table.
Gali-StarkWare
force-pushed
the
gali/xor_doc
branch
from
c7abcfc to
6f6d22b
Compare
There was a problem hiding this comment.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @alon-f and @shaharsamocha7)
crates/prover/src/examples/blake/preprocessed_columns.rs line 15 at r1 (raw file):
/// n_expand_bits), while storing another table for the n_expand_bits xor operation. /// The index_in_table is the column index in the preprocessed table (0 for the first number, 1 for /// the second number and 2 for the xor operation result).
Done.
There was a problem hiding this comment.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @alon-f)
@alon-f Sorry, you should have opened the 1000th PR when you had the chance ;)