Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update felt252-type.adoc #6790

Merged
merged 3 commits into from
Dec 2, 2024
Merged

Conversation

victorMagdesian
Copy link
Contributor

@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link
Contributor Author

@victorMagdesian victorMagdesian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @victorMagdesian)

Copy link
Collaborator

@orizi orizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @victorMagdesian)


docs/reference/src/components/cairo/modules/language_constructs/pages/felt252-type.adoc line 4 at r1 (raw file):

Field elements have the property of intentionally "wrapping around" when their value exceeds the specified range, using modular arithmetic.

limit your lines to 100 chars (3 times in this file)

Copy link
Contributor Author

@victorMagdesian victorMagdesian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @orizi)


docs/reference/src/components/cairo/modules/language_constructs/pages/felt252-type.adoc line 4 at r1 (raw file):

Previously, orizi wrote…

limit your lines to 100 chars (3 times in this file)

Resolved

Copy link
Collaborator

@orizi orizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @victorMagdesian)

@orizi orizi enabled auto-merge December 2, 2024 13:28
@orizi orizi added this pull request to the merge queue Dec 2, 2024
Merged via the queue into starkware-libs:main with commit 3d64fb3 Dec 2, 2024
48 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants