Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added option to allow conflicting paths. #6743

Merged
merged 1 commit into from
Nov 27, 2024
Merged

Added option to allow conflicting paths. #6743

merged 1 commit into from
Nov 27, 2024

Conversation

orizi
Copy link
Collaborator

@orizi orizi commented Nov 26, 2024 •
edited
Loading

Stack:

⚠️ Part of a stack created by spr. Do not merge manually using the UI - doing so may have unexpected results.

This was referenced Nov 26, 2024
Merged
Merged
@reviewable-StarkWare
Copy link

This change is Reviewable

@orizi orizi force-pushed the spr/main/46998f96 branch from b7581ff to 0e0f309 Compare November 26, 2024 15:01
@orizi orizi force-pushed the spr/main/eff05d51 branch from 7e4a655 to 4c50d3d Compare November 26, 2024 15:01
@orizi orizi mentioned this pull request Nov 26, 2024
Merged
@orizi orizi linked an issue Nov 26, 2024 that may be closed by this pull request
feat: Ignore warning #6736
Closed
2 tasks
gilbens-starkware
gilbens-starkware approved these changes Nov 27, 2024
View reviewed changes
Copy link
Contributor

@gilbens-starkware gilbens-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @orizi)

@orizi orizi force-pushed the spr/main/46998f96 branch from 0e0f309 to d7b50b2 Compare November 27, 2024 09:47
@orizi orizi changed the base branch from spr/main/eff05d51 to main November 27, 2024 09:47
@orizi orizi force-pushed the spr/main/46998f96 branch from d7b50b2 to be9772e Compare November 27, 2024 09:48
@orizi orizi enabled auto-merge November 27, 2024 09:48
@orizi orizi force-pushed the spr/main/46998f96 branch from be9772e to 0f12366 Compare November 27, 2024 09:49
@orizi
Copy link
Collaborator Author

orizi commented Nov 27, 2024

Closing pull request: commit has gone away

@orizi orizi closed this Nov 27, 2024
auto-merge was automatically disabled November 27, 2024 09:50

Pull request was closed

@orizi orizi reopened this Nov 27, 2024
@orizi orizi enabled auto-merge November 27, 2024 09:51
@orizi
Copy link
Collaborator Author

orizi commented Nov 27, 2024

Closing pull request: commit has gone away

@orizi orizi closed this Nov 27, 2024
auto-merge was automatically disabled November 27, 2024 09:51

Pull request was closed

@orizi orizi reopened this Nov 27, 2024
@orizi orizi enabled auto-merge November 27, 2024 09:53
@orizi orizi added this pull request to the merge queue Nov 27, 2024
Merged via the queue into main with commit d453e41 Nov 27, 2024
139 of 140 checks passed
@piotmag769 piotmag769 removed their request for review November 27, 2024 10:17
@orizi orizi deleted the spr/main/46998f96 branch November 28, 2024 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gilbens-starkware gilbens-starkware gilbens-starkware approved these changes

@mkaput mkaput Awaiting requested review from mkaput

@Arcticae Arcticae Awaiting requested review from Arcticae

@Draggu Draggu Awaiting requested review from Draggu

@integraledelebesgue integraledelebesgue Awaiting requested review from integraledelebesgue

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: Ignore warning
3 participants
@orizi @reviewable-StarkWare @gilbens-starkware