Moved defs plugins files to be based on external files.

[orizi]

Stack:

• Added more proper code mappings in starknet plugins. #6227
• Moved defs plugins files to be based on external files. #6225 ⬅
• Made calculating following files recursive. #6224
• Added external files. #6223

⚠️ Part of a stack created by spr. Do not merge manually using the UI - doing so may have unexpected results.

---

This change is 

[mkaput]

Reviewed 8 of 12 files at r1, all commit messages.
Reviewable status: 8 of 12 files reviewed, 1 unresolved discussion (waiting on @Arcticae, @Draggu, @gilbens-starkware, @orizi, and @piotmag769)

---

crates/cairo-lang-filesystem/src/db.rs line 115 at r1 (raw file):

    /// Returns the virtual file matching the external id.
    fn ext_as_virtual(&self, _external_id: salsa::InternId) -> VirtualFile {
        panic!("Should not be called, unless specifically implemented!");

Suggestion:

unreachable

[orizi]

Reviewable status: 8 of 12 files reviewed, 1 unresolved discussion (waiting on @Arcticae, @Draggu, @gilbens-starkware, @mkaput, and @piotmag769)

---

crates/cairo-lang-filesystem/src/db.rs line 115 at r1 (raw file):

    /// Returns the virtual file matching the external id.
    fn ext_as_virtual(&self, _external_id: salsa::InternId) -> VirtualFile {
        panic!("Should not be called, unless specifically implemented!");

it is reachable with bad config - definitely should be panic and not unreachable.

[mkaput]

Reviewed 4 of 12 files at r1.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @Arcticae, @Draggu, @gilbens-starkware, @orizi, and @piotmag769)

---

crates/cairo-lang-defs/src/ids.rs line 308 at r1 (raw file):

/// An id for a file defined out of the filesystem crate.
#[derive(Clone, Debug, Hash, PartialEq, Eq)]
pub struct ExtFileLongId(pub ModuleId, pub SyntaxStablePtrId, pub SmolStr);

use struct format. from bare declaration I have no idea that that SmolStr stores

Suggestion:

pub struct ExtFileLongId {
    pub module: ModuleId,
    pub whose_stable_ptr?: SyntaxStablePtrId,
    pub what_is_this?: SmolStr
}

---

crates/cairo-lang-defs/src/ids.rs line 309 at r1 (raw file):

#[derive(Clone, Debug, Hash, PartialEq, Eq)]
pub struct ExtFileLongId(pub ModuleId, pub SyntaxStablePtrId, pub SmolStr);
define_short_id!(ExtFileId, ExtFileLongId, DefsGroup, lookup_intern_ext_file, intern_ext_file);

TBH the choice of term external is pretty confusing to my eyes. I doubt this can ever be used for other purposed than storing plugin-generated content, so perhaps should all these types names reflect this?

Suggestion:

#[derive(Clone, Debug, Hash, PartialEq, Eq)]
pub struct PluginGeneratedFileLongId(pub ModuleId, pub SyntaxStablePtrId, pub SmolStr);
define_short_id!(PluginGeneratedFileId, PluginGeneratedFileLongId, DefsGroup, lookup_intern_plugin_generated_file, intern_plugin_generated_file);

[orizi]

Reviewable status: 10 of 12 files reviewed, 2 unresolved discussions (waiting on @Arcticae, @Draggu, @gilbens-starkware, @mkaput, and @piotmag769)

---

crates/cairo-lang-defs/src/ids.rs line 308 at r1 (raw file):

Previously, mkaput (Marek Kaput) wrote…

use struct format. from bare declaration I have no idea that that SmolStr stores

Done.

---

crates/cairo-lang-defs/src/ids.rs line 309 at r1 (raw file):

Previously, mkaput (Marek Kaput) wrote…

TBH the choice of term external is pretty confusing to my eyes. I doubt this can ever be used for other purposed than storing plugin-generated content, so perhaps should all these types names reflect this?

possibly wrong - it very well may be generated for other sort of generated file - but for the time being this would work out.

[gilbens-starkware]

Reviewed 10 of 12 files at r1, 2 of 2 files at r2, all commit messages.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @Arcticae, @Draggu, @mkaput, @orizi, and @piotmag769)

---

crates/cairo-lang-defs/src/db.rs line 621 at r2 (raw file):

    };

    let mut files = OrderedHashMap::<_, _>::default();

Suggestion:

let mut files = OrderedHashMap:::default();

[orizi]

Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @Arcticae, @Draggu, @gilbens-starkware, @mkaput, and @piotmag769)

---

crates/cairo-lang-defs/src/db.rs line 621 at r2 (raw file):

    };

    let mut files = OrderedHashMap::<_, _>::default();

this would not compile.

[mkaput]

Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Arcticae, @Draggu, @gilbens-starkware, and @piotmag769)

---

crates/cairo-lang-defs/src/ids.rs line 309 at r1 (raw file):

Previously, orizi wrote…

possibly wrong - it very well may be generated for other sort of generated file - but for the time being this would work out.

a) it could, but we can think about this when this happens
b) it took me a time to understand what actually external means => this was a confusing term :/

[gilbens-starkware]

Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @Arcticae, @Draggu, and @piotmag769)

[mkaput]

Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @Arcticae, @Draggu, and @piotmag769)