Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added finding unused imports. #6139

Merged
merged 1 commit into from
Aug 6, 2024
Merged

Added finding unused imports. #6139

merged 1 commit into from
Aug 6, 2024

Conversation

orizi
Copy link
Collaborator

@orizi orizi commented Aug 5, 2024

Non-traits and impls.


This change is Reviewable

@orizi orizi requested a review from gilbens-starkware August 5, 2024 09:25
@orizi orizi force-pushed the orizi/refactor-allowed-features branch from e2b496f to 3730080 Compare August 5, 2024 09:28
@orizi orizi force-pushed the orizi/unused-imports branch 2 times, most recently from d0e4940 to 4cbc4c6 Compare August 5, 2024 09:40
@orizi orizi force-pushed the orizi/refactor-allowed-features branch from 3730080 to 415e9d1 Compare August 5, 2024 12:39
@orizi orizi force-pushed the orizi/unused-imports branch from 4cbc4c6 to 804a117 Compare August 6, 2024 08:26
@orizi orizi changed the base branch from orizi/refactor-allowed-features to main August 6, 2024 08:26
Copy link
Member

@mkaput mkaput left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 81 of 81 files at r1, 3 of 3 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @Arcticae, @Draggu, @gilbens-starkware, and @piotmag769)

Copy link
Contributor

@gilbens-starkware gilbens-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 81 of 81 files at r1, 3 of 3 files at r2.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Arcticae, @Draggu, @orizi, and @piotmag769)


crates/cairo-lang-semantic/src/db.rs line 729 at r1 (raw file):

    ) -> Maybe<Option<TraitImplId>>;
    #[salsa::invoke(items::imp::impl_all_used_items)]
    fn impl_all_used_items(

doc

Code quote:

    #[salsa::invoke(items::imp::impl_all_used_items)]
    fn impl_all_used_items(

@orizi orizi force-pushed the orizi/unused-imports branch from 804a117 to ea861ba Compare August 6, 2024 12:15
Copy link
Contributor

@gilbens-starkware gilbens-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @Arcticae, @Draggu, and @piotmag769)

Non-traits and impls.
@orizi orizi force-pushed the orizi/unused-imports branch from ea861ba to 6068d13 Compare August 6, 2024 12:18
@orizi orizi enabled auto-merge August 6, 2024 12:18
@orizi orizi added this pull request to the merge queue Aug 6, 2024
Merged via the queue into main with commit 6246ef0 Aug 6, 2024
44 checks passed
@piotmag769 piotmag769 removed their request for review August 6, 2024 13:13
@orizi orizi deleted the orizi/unused-imports branch August 6, 2024 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants