chore: remove all instances of inline(always) from corelib

[javra]

As suggested by @orizi in the discussion to PR #5911.

---

This change is 

[orizi]

Reviewed 25 of 25 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @javra)

---

corelib/src/option.cairo line 56 at r1 (raw file):

    fn unwrap(self: Option<T>) -> T {
        self.expect('Option::unwrap failed.')
    }

these are a must - without your builds would crash.

Suggestion:

    #[inline(never)]
    fn expect(self: Option<T>, err: felt252) -> T {
        match self {
            Option::Some(x) => x,
            Option::None => core::panic_with_felt252(err),
        }
    }

    #[inline(never)]
    fn unwrap(self: Option<T>) -> T {
        self.expect('Option::unwrap failed.')
    }

[orizi]

Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @javra)

a discussion (no related file):
@ilyalesokhin-starkware for 2nd eye.

---

[javra]

Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @orizi)

---

corelib/src/option.cairo line 56 at r1 (raw file):

Previously, orizi wrote…

these are a must - without your builds would crash.

Did you mean to add never? They were inline(always) before.

What's special about unwrap and expect in terms of inlining? You already mentioned it on the other PR and I tested it on a small example which didn't crash.

[orizi]

Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @javra)

---

corelib/src/option.cairo line 56 at r1 (raw file):

Previously, javra (Jakob von Raumer) wrote…

Did you mean to add never? They were inline(always) before.

What's special about unwrap and expect in terms of inlining? You already mentioned it on the other PR and I tested it on a small example which didn't crash.

i meant always - sorry.

it is required due to code doing withdraw_gas().unwrap() (or expect).
if it isn't inlined - gas variables won't be able to properly be solved.

[javra]

Reviewable status: 24 of 25 files reviewed, 2 unresolved discussions (waiting on @orizi)

---

corelib/src/option.cairo line 56 at r1 (raw file):

Previously, orizi wrote…

i meant always - sorry.

it is required due to code doing withdraw_gas().unwrap() (or expect).
if it isn't inlined - gas variables won't be able to properly be solved.

Done.

[orizi]

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @javra)

[javra]

@ilyalesokhin-starkware

[javra]

Can we move this forward before it rots more than it already has? 😅 cc @orizi

[orizi]

Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @javra)

[orizi]

yes - sorry - unblocking - rebase and i'll merge.

Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @javra)

[javra]

done 👍

Reviewable status: 1 of 25 files reviewed, all discussions resolved (waiting on @orizi)

[orizi]

Reviewed 24 of 24 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @javra)