Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed redundent block copied from borrow-check analysis. #5270

Merged
merged 1 commit into from
Mar 17, 2024
Merged

Removed redundent block copied from borrow-check analysis. #5270

merged 1 commit into from
Mar 17, 2024

Conversation

orizi
Copy link
Collaborator

@orizi orizi commented Mar 15, 2024 •
edited by bbrandtom
Loading

Stack:

⚠️ Part of a stack created by spr. Do not merge manually using the UI - doing so may have unexpected results.

This change is Reviewable

This was referenced Mar 15, 2024
Merged
Merged
Merged
Merged
ilyalesokhin-starkware
ilyalesokhin-starkware approved these changes Mar 17, 2024
View reviewed changes
Copy link
Contributor

@ilyalesokhin-starkware ilyalesokhin-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 12 of 12 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @orizi)

@orizi orizi changed the base branch from pr/orizi/mem-usage/4b149b6c to main March 17, 2024 07:43
@orizi orizi force-pushed the pr/orizi/mem-usage/656cce37 branch from 19d31ef to 259eadc Compare March 17, 2024 07:43
@orizi orizi changed the title Removed redundent block copied from borrow-check analysis. Made sierra-gen have a single construction vector for statements. Mar 17, 2024
@orizi orizi force-pushed the pr/orizi/mem-usage/656cce37 branch from 259eadc to d2225d3 Compare March 17, 2024 08:10
@orizi orizi changed the title Made sierra-gen have a single construction vector for statements. Using UnorderedMap in reorder statement. Mar 17, 2024
@orizi orizi changed the title Using UnorderedMap in reorder statement. Removed redundent block copied from borrow-check analysis. Mar 17, 2024
@orizi orizi changed the base branch from main to pr/orizi/mem-usage/4b149b6c March 17, 2024 08:48
@orizi orizi changed the base branch from pr/orizi/mem-usage/4b149b6c to main March 17, 2024 08:54
@orizi orizi force-pushed the pr/orizi/mem-usage/656cce37 branch from d2225d3 to 84005d5 Compare March 17, 2024 08:54
@orizi orizi enabled auto-merge March 17, 2024 08:54
@orizi orizi added this pull request to the merge queue Mar 17, 2024
Merged via the queue into main with commit 309670b Mar 17, 2024
84 of 85 checks passed
@orizi orizi deleted the pr/orizi/mem-usage/656cce37 branch April 17, 2024 16:30
shramee pushed a commit to shramee/cairo that referenced this pull request Sep 17, 2024
@orizi @shramee
Removed redundent block copied from borrow-check analysis. (starkware…
ee11a77 
…-libs#5270)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilyalesokhin-starkware ilyalesokhin-starkware ilyalesokhin-starkware approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@orizi @ilyalesokhin-starkware