Fix cfg attribute for TEST_CLASS_HASH #5219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maciektr
force-pushed
the
maciektr/fix-test-cfg
branch
from
6cf626a to
5359aa4
Compare
orizi
requested changes
Mar 7, 2024
There was a problem hiding this comment.
Reviewable status: 0 of 13 files reviewed, 1 unresolved discussion (waiting on @maciektr and @mkaput)
a discussion (no related file):
target 2.6.2 instead.
maciektr
force-pushed
the
maciektr/fix-test-cfg
branch
from
5359aa4 to
acae667
Compare
maciektr
force-pushed
the
maciektr/fix-test-cfg
branch
from
acae667 to
a602cbe
Compare
orizi
approved these changes
Mar 7, 2024
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1, 11 of 11 files at r2, 57 of 57 files at r4, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @maciektr and @mkaput)
mkaput
requested changes
Mar 7, 2024
orizi
approved these changes
Mar 7, 2024
There was a problem hiding this comment.
Reviewable status:
complete! all files reviewed, all discussions resolved (waiting on @maciektr)
mkaput
approved these changes
Mar 8, 2024
There was a problem hiding this comment.
Reviewable status:
shramee
pushed a commit
to shramee/cairo
that referenced
this pull request
Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is