-
Notifications
You must be signed in to change notification settings - Fork 581
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: OverflowingSub trait #5164
feat: OverflowingSub trait #5164
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 5 of 5 files at r1, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @enitrat)
a discussion (no related file):
@gilbens-starkware for 2nd eye.
corelib/src/num/traits/ops/overflowing.cairo
line 12 at r1 (raw file):
pub trait OverflowingSub<T> { /// Returns a tuple of the difference along with a boolean indicating whether an arithmetic overflow /// would occur.
Suggestion:
/// Returns a tuple of the difference along with a boolean indicating whether an arithmetic
/// overflow would occur.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 4 of 5 files reviewed, 2 unresolved discussions (waiting on @orizi)
corelib/src/num/traits/ops/overflowing.cairo
line 12 at r1 (raw file):
pub trait OverflowingSub<T> { /// Returns a tuple of the difference along with a boolean indicating whether an arithmetic overflow /// would occur.
Done. What's the correct line length to use?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @enitrat)
corelib/src/num/traits/ops/overflowing.cairo
line 12 at r1 (raw file):
Previously, enitrat (Mathieu) wrote…
Done. What's the correct line length to use?
100 chars.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @enitrat)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 4 of 5 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @enitrat)
6fe4987
This change is![Reviewable](https://camo.githubusercontent.com/1541c4039185914e83657d3683ec25920c672c6c5c7ab4240ee7bff601adec0b/68747470733a2f2f72657669657761626c652e696f2f7265766965775f627574746f6e2e737667)