Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: OverflowingSub trait #5164

Merged
merged 3 commits into from
Feb 29, 2024

Conversation

enitrat
Copy link
Contributor

@enitrat enitrat commented Feb 28, 2024

This change is Reviewable

Copy link
Collaborator

@orizi orizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 5 of 5 files at r1, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @enitrat)

a discussion (no related file):
@gilbens-starkware for 2nd eye.



corelib/src/num/traits/ops/overflowing.cairo line 12 at r1 (raw file):

pub trait OverflowingSub<T> {
    /// Returns a tuple of the difference along with a boolean indicating whether an arithmetic overflow
    /// would occur.

Suggestion:

    /// Returns a tuple of the difference along with a boolean indicating whether an arithmetic
    /// overflow would occur.

Copy link
Contributor Author

@enitrat enitrat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 4 of 5 files reviewed, 2 unresolved discussions (waiting on @orizi)


corelib/src/num/traits/ops/overflowing.cairo line 12 at r1 (raw file):

pub trait OverflowingSub<T> {
    /// Returns a tuple of the difference along with a boolean indicating whether an arithmetic overflow
    /// would occur.

Done. What's the correct line length to use?

Copy link
Collaborator

@orizi orizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @enitrat)


corelib/src/num/traits/ops/overflowing.cairo line 12 at r1 (raw file):

Previously, enitrat (Mathieu) wrote…

Done. What's the correct line length to use?

100 chars.

Copy link
Collaborator

@orizi orizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @enitrat)

Copy link
Contributor

@gilbens-starkware gilbens-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 4 of 5 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @enitrat)

@gilbens-starkware gilbens-starkware added this pull request to the merge queue Feb 29, 2024
Merged via the queue into starkware-libs:main with commit 6fe4987 Feb 29, 2024
42 of 43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants