Allow renaming a variable twice as it might happen in some cases.

[ilyalesokhin-starkware]

This change is 

[orizi]

Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion (waiting on @ilyalesokhin-starkware)

---

crates/cairo-lang-lowering/src/optimizations/cancel_ops.rs line 41 at r1 (raw file):

    // Remove no-longer needed statements.
    stmts_to_remove.sort_by_key(|(block_id, stmt_id)| (block_id.0, *stmt_id));
    for (block_id, stmt_id) in stmts_to_remove.into_iter().rev().dedup() {

how do you know the problematic ones would be consecutive?
doc how you know it, and why these might exist.

Code quote:

    for (block_id, stmt_id) in stmts_to_remove.into_iter().rev().dedup() {

[ilyalesokhin-starkware]

crates/cairo-lang-lowering/src/optimizations/cancel_ops.rs line 41 at r1 (raw file):

Previously, orizi wrote…

how do you know the problematic ones would be consecutive?
doc how you know it, and why these might exist.

because of the sorting.

[orizi]

Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion (waiting on @ilyalesokhin-starkware)

---

crates/cairo-lang-lowering/src/optimizations/cancel_ops.rs line 41 at r1 (raw file):

Previously, ilyalesokhin-starkware wrote…

because of the sorting.

oh - right - but still doc the need for dedup.

[ilyalesokhin-starkware]

Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion (waiting on @orizi)

---

crates/cairo-lang-lowering/src/optimizations/cancel_ops.rs line 41 at r1 (raw file):

Previously, orizi wrote…

oh - right - but still doc the need for dedup.

Done.
I couldn't put the .dedup() before the .rev().

[orizi]

Reviewed 1 of 2 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @ilyalesokhin-starkware)