Support feature at module and fn level.

[orizi]

Stack:

• Bumped version to 2.5.1. #4943
• Made integer overflowing ops pub. #4942
• Support feature at module and fn level. #4941 ⬅

⚠️ Part of a stack created by spr. Do not merge manually using the UI - doing so may have unexpected results.

---

This change is 

[gilbens-starkware]

Reviewed 7 of 8 files at r1, all commit messages.
Reviewable status: 7 of 8 files reviewed, 2 unresolved discussions (waiting on @orizi)

---

crates/cairo-lang-semantic/src/expr/compute.rs line 268 at r1 (raw file):

                diagnostics,
            ),
        };

Consider implementing QueryAttrs for LookupItemId and then just extract_allowed_features it.

Code quote:

        let allowed_features = match lookup_item_id {
            LookupItemId::ModuleItem(id) => extract_allowed_features(
                semantic_db,
                &id.stable_location(defs_db).syntax_node(defs_db),
                diagnostics,
            ),
            LookupItemId::TraitItem(id) => extract_allowed_features(
                semantic_db,
                &id.stable_location(defs_db).syntax_node(defs_db),
                diagnostics,
            ),
            LookupItemId::ImplItem(id) => extract_allowed_features(
                semantic_db,
                &id.stable_location(defs_db).syntax_node(defs_db),
                diagnostics,
            ),
        };

---

crates/cairo-lang-semantic/src/expr/compute.rs line 2507 at r1 (raw file):

}

/// Returns the allowed features of a query

Suggestion:

an object which supports attributes.

[orizi]

Reviewable status: 7 of 8 files reviewed, 2 unresolved discussions (waiting on @gilbens-starkware)

---

crates/cairo-lang-semantic/src/expr/compute.rs line 268 at r1 (raw file):

Previously, gilbens-starkware (Gil Ben-Shachar) wrote…

Consider implementing QueryAttrs for LookupItemId and then just extract_allowed_features it.

can't - trait is defined on syntax, and ids are defined on defs.

---

crates/cairo-lang-semantic/src/expr/compute.rs line 2507 at r1 (raw file):

}

/// Returns the allowed features of a query

Done.

[gilbens-starkware]

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @orizi)