Change end of program relocation to point after the const segment. #4714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gilbens-starkware
force-pushed
the
spr/main/c2923fab
branch
from
c3f2cd3 to
a571bfa
Compare
gilbens-starkware
force-pushed
the
spr/main/ef16e798
branch
from
efa9bf9 to
12f9a7f
Compare
gilbens-starkware
force-pushed
the
spr/main/c2923fab
branch
from
a571bfa to
08d7af0
Compare
gilbens-starkware
force-pushed
the
spr/main/ef16e798
branch
from
12f9a7f to
e9ff3fc
Compare
orizi
approved these changes
Jan 2, 2024
There was a problem hiding this comment.
Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @gilbens-starkware)
gilbens-starkware
force-pushed
the
spr/main/c2923fab
branch
from
08d7af0 to
217a78b
Compare
gilbens-starkware
force-pushed
the
spr/main/ef16e798
branch
from
e9ff3fc to
2b5361b
Compare
orizi
approved these changes
Jan 2, 2024
There was a problem hiding this comment.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status:
commit-id:c2923fab
commit-id:ef16e798
gilbens-starkware
force-pushed
the
spr/main/c2923fab
branch
from
217a78b to
2d644e5
Compare
gilbens-starkware
force-pushed
the
spr/main/ef16e798
branch
from
2b5361b to
4507831
Compare
gilbens-starkware
removed this pull request from the merge queue due to a manual request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
commit-id:ef16e798
Stack:
This change is