Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added error for nopanic cycles. #4643

Merged
merged 1 commit into from
Jan 2, 2024
Merged

Added error for nopanic cycles. #4643

merged 1 commit into from
Jan 2, 2024

Conversation

orizi
Copy link
Collaborator

@orizi orizi commented Dec 21, 2023

This change is Reviewable

@orizi orizi requested a review from liorgold2 December 21, 2023 17:44
@orizi orizi force-pushed the orizi/prevent-nopanic-cycle branch 4 times, most recently from df044ef to 514a3a0 Compare December 24, 2023 06:51
@orizi orizi force-pushed the orizi/prevent-nopanic-cycle branch from 514a3a0 to 42fc7bd Compare January 2, 2024 14:09
Copy link
Contributor

@gilbens-starkware gilbens-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 7 of 7 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @liorgold2 and @orizi)


crates/cairo-lang-lowering/src/diagnostic.rs line 89 at r1 (raw file):

            }
            LoweringDiagnosticKind::NoPanicFunctionCycle => {
                "`nopanic` function call cycle.".into()

Or something similar

Suggestion:

"Call cycle in a `nopanic` function is not allowed."

@orizi orizi force-pushed the orizi/prevent-nopanic-cycle branch from 42fc7bd to 5bd9aa4 Compare January 2, 2024 14:15
Copy link
Collaborator Author

@orizi orizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 5 of 7 files reviewed, 1 unresolved discussion (waiting on @gilbens-starkware and @liorgold2)


crates/cairo-lang-lowering/src/diagnostic.rs line 89 at r1 (raw file):

Previously, gilbens-starkware (Gil Ben-Shachar) wrote…

Or something similar

Done.

@orizi orizi enabled auto-merge January 2, 2024 14:15
Copy link
Contributor

@gilbens-starkware gilbens-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r3, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @liorgold2)

@orizi orizi added this pull request to the merge queue Jan 2, 2024
Copy link
Contributor

@gilbens-starkware gilbens-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @liorgold2)

Merged via the queue into main with commit a666087 Jan 2, 2024
39 checks passed
@orizi orizi deleted the orizi/prevent-nopanic-cycle branch January 15, 2024 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants