-
Notifications
You must be signed in to change notification settings - Fork 581
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added error for nopanic cycles. #4643
Conversation
df044ef
to
514a3a0
Compare
514a3a0
to
42fc7bd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 7 of 7 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @liorgold2 and @orizi)
crates/cairo-lang-lowering/src/diagnostic.rs
line 89 at r1 (raw file):
} LoweringDiagnosticKind::NoPanicFunctionCycle => { "`nopanic` function call cycle.".into()
Or something similar
Suggestion:
"Call cycle in a `nopanic` function is not allowed."
42fc7bd
to
5bd9aa4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 5 of 7 files reviewed, 1 unresolved discussion (waiting on @gilbens-starkware and @liorgold2)
crates/cairo-lang-lowering/src/diagnostic.rs
line 89 at r1 (raw file):
Previously, gilbens-starkware (Gil Ben-Shachar) wrote…
Or something similar
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r3, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @liorgold2)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status:
complete! all files reviewed, all discussions resolved (waiting on @liorgold2)
This change is![Reviewable](https://camo.githubusercontent.com/1541c4039185914e83657d3683ec25920c672c6c5c7ab4240ee7bff601adec0b/68747470733a2f2f72657669657761626c652e696f2f7265766965775f627574746f6e2e737667)