Pass Call::calldata as a Span. #4620
Conversation
There was a problem hiding this comment.
Reviewable status: 0 of 6 files reviewed, 1 unresolved discussion (waiting on @ArielElp and @orizi)
corelib/src/starknet/account.cairo line 7 at r1 (raw file):
pub to: ContractAddress, pub selector: felt252, pub calldata: Span<felt252>
@ArielElp can we merge this change?
Code quote:
pub calldata: Span<felt252>
There was a problem hiding this comment.
Reviewed 6 of 6 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @orizi)
corelib/src/starknet/account.cairo line 7 at r1 (raw file):
Previously, ilyalesokhin-starkware wrote…
@ArielElp can we merge this change?
yes
ilyalesokhin-starkware
force-pushed
the
ilya/span_account
branch
from
efeb898 to
34ba565
Compare
There was a problem hiding this comment.
Reviewed 2 of 6 files at r1, 4 of 4 files at r2, all commit messages.
Reviewable status:
There was a problem hiding this comment.
Reviewed all commit messages.
Reviewable status:
ilyalesokhin-starkware
force-pushed
the
ilya/span_account
branch
from
34ba565 to
3577a38
Compare
This change is