Improve Span deserialization.

[ilyalesokhin-starkware]

This change is 

[orizi]

Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @ilyalesokhin-starkware)

---

corelib/src/array.cairo line 147 at r1 (raw file):

        serialized = serialized.slice(length, serialized.len() - length);
        Option::Some(Span { snapshot: res })
    }

you probably need to make this impl have a negative param - and have a specific impl for Span

Code quote:

        let length = *serialized.pop_front()?;;
        let res = serialized.slice(0, length);
        serialized = serialized.slice(length, serialized.len() - length);
        Option::Some(Span { snapshot: res })
    }

[ilyalesokhin-starkware]

Reviewable status: 0 of 3 files reviewed, 1 unresolved discussion (waiting on @orizi)

---

corelib/src/array.cairo line 147 at r1 (raw file):

Previously, orizi wrote…

you probably need to make this impl have a negative param - and have a specific impl for Span

Done.

[orizi]

Reviewed 1 of 3 files at r2.
Reviewable status: 1 of 3 files reviewed, 3 unresolved discussions (waiting on @ilyalesokhin-starkware)

---

corelib/src/array.cairo line 7 at r2 (raw file):

use core::option::OptionTrait;
use core::serde::Serde;
use core::metaprogramming::{TypeEqual, TypeEqualImpl};

Suggestion:

use core::metaprogramming::TypeEqual;

---

corelib/src/lib.cairo line 355 at r2 (raw file):

// Metaprogramming.
pub mod metaprogramming;

Suggestion:

// Metaprogramming.
mod metaprogramming;

---

corelib/src/metaprogramming.cairo line 5 at r2 (raw file):

pub trait TypeEqual<S, T> {}

pub impl TypeEqualImpl<T> of TypeEqual<T, T>;

Suggestion:

/// A trait that can be used to disable implementations based on the types of the generic args.
/// Assumes that `TypeEqualImpl` is the only implementation of this trait.
pub trait TypeEqual<S, T> {}

impl TypeEqualImpl<T> of TypeEqual<T, T>;

[ilyalesokhin-starkware]

corelib/src/lib.cairo line 355 at r2 (raw file):

// Metaprogramming.
pub mod metaprogramming;

why?
A user might want to use TypeEqual

[ilyalesokhin-starkware]

corelib/src/metaprogramming.cairo line 5 at r2 (raw file):

pub trait TypeEqual<S, T> {}

pub impl TypeEqualImpl<T> of TypeEqual<T, T>;

what about the idea that only pub impls can be infered?

[ilyalesokhin-starkware]

Reviewable status: 1 of 3 files reviewed, 3 unresolved discussions (waiting on @orizi)

---

corelib/src/array.cairo line 7 at r2 (raw file):

use core::option::OptionTrait;
use core::serde::Serde;
use core::metaprogramming::{TypeEqual, TypeEqualImpl};

Done.

[orizi]

Reviewed 1 of 3 files at r2, 1 of 1 files at r3, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @ilyalesokhin-starkware)

---

corelib/src/metaprogramming.cairo line 5 at r2 (raw file):

Previously, ilyalesokhin-starkware wrote…

what about the idea that only pub impls can be infered?

we have decided against it.

[ilyalesokhin-starkware]

Reviewable status: 2 of 3 files reviewed, 2 unresolved discussions (waiting on @orizi)

---

corelib/src/metaprogramming.cairo line 5 at r2 (raw file):

Previously, orizi wrote…

we have decided against it.

Done.

[orizi]

Reviewed 1 of 1 files at r4, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @ilyalesokhin-starkware)