Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: minor typos #4500

Merged
merged 13 commits into from
Jan 15, 2024
Merged

fix: minor typos #4500

merged 13 commits into from
Jan 15, 2024

Conversation

tudorpintea999
Copy link
Contributor

@tudorpintea999 tudorpintea999 commented Dec 1, 2023

Hello
I fixed some typos in the docs.
Hope it helps.
Br,
Tudor.


This change is Reviewable

Copy link
Collaborator

@orizi orizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there's a CI for typos now - feel free to rebase if your suggestions were not fixed by it just yet.

Reviewable status: 0 of 7 files reviewed, all discussions resolved

Copy link
Collaborator

@orizi orizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 7 files at r1, all commit messages.
Reviewable status: 2 of 7 files reviewed, 5 unresolved discussions (waiting on @tudorpintea999)


corelib/src/starknet/testing.cairo line 6 at r1 (raw file):

use core::traits::Into;

// A general cheatcode function used to simplify the implementation of Starknet testing functions.

revert


docs/reference/src/components/cairo/modules/appendices/pages/contribution-guidelines.adoc line 12 at r1 (raw file):

You've found a bug in the source code, a mistake in the documentation or maybe you'd like a new
feature? Take a look at the link:https://github.com/starkware-libs/cairo/discussions[GitHub Discussions] to see if it's already being discussed.  You can

revert


docs/reference/src/components/cairo/modules/getting_started/pages/prerequisites.adoc line 29 at r1 (raw file):

1 . Download and install link:https://code.visualstudio.com/[VSCode].

2 . Follow the instructions in the link:https://github.com/starkware-libs/cairo/blob/main/vscode-cairo/README.md[vscode-cairo].

Suggestion:

1 . Download and install link:https://code.visualstudio.com/[VSCode].

2 . Follow the instructions in link:https://github.com/starkware-libs/cairo/blob/main/vscode-cairo/README.md[vscode-cairo].

docs/reference/src/components/cairo/modules/ROOT/pages/how-to-contribute.adoc line 51 at r1 (raw file):

- We encourage developers to ask and answer questions on https://stackoverflow.com/questions/tagged/cairo-lang[stackoverflow].
- Contact options listed on the link:https://github.com/starkware-libs[this GitHub profile]

revert


docs/reference/src/components/cairo/modules/ROOT/pages/index.adoc line 19 at r1 (raw file):

more about Sierra link:https://medium.com/starkware/cairo-1-0-aa96eefb19a0[here].

If you are looking for Cairo 0 documentation, please see the link:https://www.cairo-lang.org/docs/0.12.0/hello_cairo/index.html[here].

revert

Copy link
Collaborator

@orizi orizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 7 files at r1, 1 of 1 files at r2, 1 of 1 files at r3, 1 of 1 files at r4.
Reviewable status: 6 of 7 files reviewed, 3 unresolved discussions (waiting on @tudorpintea999)

Copy link
Collaborator

@orizi orizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r5, 1 of 1 files at r6, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @tudorpintea999)

@orizi orizi enabled auto-merge January 15, 2024 17:47
Copy link
Collaborator

@orizi orizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r7, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @tudorpintea999)

@orizi orizi added this pull request to the merge queue Jan 15, 2024
Merged via the queue into starkware-libs:main with commit 674984e Jan 15, 2024
42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants