Avoid pushing zero-sized variables.

[ilyalesokhin-starkware]

This change is 

[ilyalesokhin-starkware]

Reviewable status: 0 of 32 files reviewed, 1 unresolved discussion (waiting on @orizi)

---

crates/cairo-lang-starknet/test_data/new_syntax_test_contract__counter_contract.sierra line 1658 at r1 (raw file):

rename<Array<felt252>>([7]) -> ([10]); // 1328
rename<Array<felt252>>([8]) -> ([11]); // 1329
jump() { 1365() }; // 1330

the store_temps before the jump were changed to renames and now the code fails sierra to casm.

Code quote:

function_call<user@cairo_level_tests::contracts::new_syntax_test_contract::test_component::EventIsEvent::append_keys_and_data>([3], [1], [2]) -> ([7], [8], [9]); // 1326
drop<Unit>([9]) -> (); // 1327
rename<Array<felt252>>([7]) -> ([10]); // 1328
rename<Array<felt252>>([8]) -> ([11]); // 1329
jump() { 1365() }; // 1330

[ilyalesokhin-starkware]

Reviewable status: 0 of 32 files reviewed, 1 unresolved discussion (waiting on @orizi)

---

crates/cairo-lang-starknet/test_data/new_syntax_test_contract__counter_contract.sierra line 1658 at r1 (raw file):

Previously, ilyalesokhin-starkware wrote…

the store_temps before the jump were changed to renames and now the code fails sierra to casm.

See
https://reviewable.io/reviews/starkware-libs/cairo/4276

[orizi]

Reviewed 31 of 32 files at r1, 21 of 21 files at r2, all commit messages.
Reviewable status: 52 of 53 files reviewed, 1 unresolved discussion (waiting on @ilyalesokhin-starkware)

---

crates/cairo-lang-starknet/test_data/new_syntax_test_contract__counter_contract.sierra line 1658 at r1 (raw file):

Previously, ilyalesokhin-starkware wrote…

See
https://reviewable.io/reviews/starkware-libs/cairo/4276

so why don't i see the tests failing?

[ilyalesokhin-starkware]

crates/cairo-lang-starknet/test_data/new_syntax_test_contract__counter_contract.sierra line 1658 at r1 (raw file):

Previously, orizi wrote…

so why don't i see the tests failing?

I'ved rebased this on top of the fix.
you can look at the previous ci run.

[orizi]

Reviewed 1 of 32 files at r1.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @ilyalesokhin-starkware)

[ilyalesokhin-starkware]

We need to merge
https://reviewable.io/reviews/starkware-libs/cairo/4276#-
first.
Note that is changes sierra_to_casm.

Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @ilyalesokhin-starkware)

[ilyalesokhin-starkware]

Replaced by #4290