-
Notifications
You must be signed in to change notification settings - Fork 581
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changed enum derive store implementation. #3817
Conversation
crates/cairo-lang-starknet/src/plugin/plugin_test_data/user_defined_types
Show resolved
Hide resolved
crates/cairo-lang-starknet/src/plugin/plugin_test_data/user_defined_types
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 2 files reviewed, 2 unresolved discussions (waiting on @ArielElp, @LucasLvy, and @spapinistarkware)
crates/cairo-lang-starknet/src/plugin/plugin_test_data/user_defined_types
line 32 at r1 (raw file):
Previously, LucasLvy (Lucas @ StarkWare) wrote…
#[derive(Drop, Serde, starknet::Store, Default)] enum EnumWithDefault { A: u8, #[default] B: u16, C: u32, }
I think it should derive default also
that can happen only after Default
derive exists.
crates/cairo-lang-starknet/src/plugin/plugin_test_data/user_defined_types
line 79 at r1 (raw file):
Previously, LucasLvy (Lucas @ StarkWare) wrote…
#[derive(Drop, Serde, starknet::Store, Default)] enum EnumWithDefault { A: u8, #[default] B: u16, C: u32, }
that can happen only after Default
derive exists.
122aa85
to
4819c63
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @ArielElp and @LucasLvy)
4819c63
to
1bc6536
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @ArielElp and @LucasLvy)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 2 files at r2, 1 of 1 files at r3, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @ArielElp)
1bc6536
to
ad2c889
Compare
This change is![Reviewable](https://camo.githubusercontent.com/1541c4039185914e83657d3683ec25920c672c6c5c7ab4240ee7bff601adec0b/68747470733a2f2f72657669657761626c652e696f2f7265766965775f627574746f6e2e737667)