Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed enum derive store implementation. #3817

Merged
merged 1 commit into from
Aug 2, 2023

Conversation

orizi
Copy link
Collaborator

@orizi orizi commented Aug 1, 2023

This change is Reviewable

Copy link
Collaborator Author

@orizi orizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 2 files reviewed, 2 unresolved discussions (waiting on @ArielElp, @LucasLvy, and @spapinistarkware)


crates/cairo-lang-starknet/src/plugin/plugin_test_data/user_defined_types line 32 at r1 (raw file):

Previously, LucasLvy (Lucas @ StarkWare) wrote…
    #[derive(Drop, Serde, starknet::Store, Default)]
    enum EnumWithDefault {
        A: u8,
        #[default]
        B: u16,
        C: u32,
    }

I think it should derive default also

that can happen only after Default derive exists.


crates/cairo-lang-starknet/src/plugin/plugin_test_data/user_defined_types line 79 at r1 (raw file):

Previously, LucasLvy (Lucas @ StarkWare) wrote…
    #[derive(Drop, Serde, starknet::Store, Default)]
    enum EnumWithDefault {
        A: u8,
        #[default]
        B: u16,
        C: u32,
    }

that can happen only after Default derive exists.

@orizi orizi changed the base branch from main to dev-v2.1.0 August 2, 2023 04:51
@orizi orizi force-pushed the orizi/enum-store-derive-fix branch 2 times, most recently from 122aa85 to 4819c63 Compare August 2, 2023 05:03
Copy link
Contributor

@spapinistarkware spapinistarkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @ArielElp and @LucasLvy)

@orizi orizi force-pushed the orizi/enum-store-derive-fix branch from 4819c63 to 1bc6536 Compare August 2, 2023 10:17
Copy link
Collaborator Author

@orizi orizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @ArielElp and @LucasLvy)

@orizi orizi enabled auto-merge August 2, 2023 10:18
Copy link
Contributor

@0xLucqs 0xLucqs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 2 files at r2, 1 of 1 files at r3, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @ArielElp)

@orizi orizi force-pushed the orizi/enum-store-derive-fix branch from 1bc6536 to ad2c889 Compare August 2, 2023 10:26
@orizi orizi added this pull request to the merge queue Aug 2, 2023
Merged via the queue into dev-v2.1.0 with commit 03c3864 Aug 2, 2023
@orizi orizi deleted the orizi/enum-store-derive-fix branch August 10, 2023 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants