Check the parity of y in non-montgomery.

[ilyalesokhin-starkware]

This change is 

[orizi]

Reviewed 1 of 2 files at r1, all commit messages.
Reviewable status: 1 of 2 files reviewed, 1 unresolved discussion (waiting on @ilyalesokhin-starkware)

a discussion (no related file):
make dev-v2.1.0 the target.

---

[orizi]

Reviewed 1 of 2 files at r1.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @ilyalesokhin-starkware)

---

corelib/src/test/secp256r1_test.cairo line 87 at r1 (raw file):

    let r: u256 = 0x7380df4a623c5c2259a5e5f5b225d7265a9e24b3a13c101d1afddcf29e3cf8b2;
    let s: u256 = 0x0d131afacdd17a4ea1b544bb3ade677ff8accbe7830e15b9c225e6031155946a;
    let y_parity = false;

Suggestion:

    let x: u256 = 0x502a43ce77c6f5c736a82f847fa95f8c2d483fe223b12b91047d83258a958b0f;
    let y: u256 = 0xdb0a2e6710c71ba80afeb3abdf69d306ce729c7704f4ddf2eaaf0b76209fe1b0;
    let r: u256 = 0x7380df4a623c5c2259a5e5f5b225d7265a9e24b3a13c101d1afddcf29e3cf8b2;
    let s: u256 = 0x0d131afacdd17a4ea1b544bb3ade677ff8accbe7830e15b9c225e6031155946a;
    let y_parity = y & 1 == 1;

[orizi]

Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @ilyalesokhin-starkware)

---

corelib/src/test/secp256r1_test.cairo line 93 at r1 (raw file):

    let (recovered_x, recovered_y) = recovered.get_coordinates().unwrap_syscall();
    let is_valid = recovered_x == x;
    assert(is_valid, 'Signature is not valid');

.

Suggestion:

    assert_eq(@recovered_x, @x, 'Signature is not valid');

[ilyalesokhin-starkware]

Reviewable status: 1 of 2 files reviewed, 3 unresolved discussions (waiting on @orizi)

a discussion (no related file):

Previously, orizi wrote…

make dev-v2.1.0 the target.

Done.

---

---

corelib/src/test/secp256r1_test.cairo line 87 at r1 (raw file):

    let r: u256 = 0x7380df4a623c5c2259a5e5f5b225d7265a9e24b3a13c101d1afddcf29e3cf8b2;
    let s: u256 = 0x0d131afacdd17a4ea1b544bb3ade677ff8accbe7830e15b9c225e6031155946a;
    let y_parity = false;

that not the parity of this y.

---

corelib/src/test/secp256r1_test.cairo line 93 at r1 (raw file):

Previously, orizi wrote…

.

Done.

[orizi]

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @ilyalesokhin-starkware)